LEICA BigTIFF

[Agelos Pappas]

Oops, forgot to commit the changes. It's there now.

https://github.com/openslide/openslide/pull/97

On 30/7/2012 3:56 μμ, Agelos Pappas wrote:
> Hi Benjamin,
>
> I just committed a new version of the leica vendor file, which fixes 
> most of the issues that you pointed out. I have one question about one 
> of your remarks.
> You wrote that "Name constants should be static const arrays like 
> LEICA_DESCRIPTION". Does this mean that I should declare as arrays 
> every xml property request and every XPATH query?
>
> i.e. do the following, for example, need to be declared as const arrays:
>
> result = xmlXPathEvalExpression(BAD_CAST "new:pixels/new:dimension", 
> context);
> str = xmlGetProp(result->nodesetval->nodeTab[0], BAD_CAST "version");
>
> Regards
> Agelos
>
> On 21/7/2012 12:33 πμ, Benjamin Gilbert wrote:
>> On 07/20/2012 06:29 AM, Agelos Pappas wrote:
>>> Done, let me know if it works!
>> It looks as though you didn't make your commit on top of mine, so mine
>> didn't end up in the pull request.  Not a big deal; I'll deal with that
>> when I merge.
>>
>> I'll post review comments directly to the pull request, hopefully within
>> the next day or so.
>>
>> --Benjamin Gilbert
>> _______________________________________________
>> openslide-users mailing list
>> openslide-users at lists.andrew.cmu.edu
>> https://lists.andrew.cmu.edu/mailman/listinfo/openslide-users
>>
>>
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2012.0.2197 / Virus Database: 2437/5143 - Release Date: 
>> 07/20/12
>>
>>
>