Agelos Pappas agelos at smartcode.gr
Wed Aug 8 08:08:38 EDT 2012

Hi Benjamin,

I just committed an updated version of the leica vendor file, which 
hopefully deals with all the issues you pointed out.
Thanks again for taking the time to review it.


On 30/7/2012 8:54 μμ, Benjamin Gilbert wrote:
> On 07/30/2012 08:56 AM, Agelos Pappas wrote:
>> I just committed a new version of the leica vendor file, which fixes
>> most of the issues that you pointed out.
> Great, I'll take a look when I can.
>> You wrote that "Name constants should be static const arrays like
>> LEICA_DESCRIPTION". Does this mean that I should declare as arrays every
>> xml property request and every XPATH query?
>> i.e. do the following, for example, need to be declared as const arrays:
>> result = xmlXPathEvalExpression(BAD_CAST "new:pixels/new:dimension",
>> context);
>> str = xmlGetProp(result->nodesetval->nodeTab[0], BAD_CAST "version");
> The observation that prompted the comment was that in some cases you
> were hardcoding the same string multiple times.  For XML properties, it
> should be fairly straightforward to use static const arrays (which could
> already be of xmlChar[] type), so I'd be inclined to do so.  XPath
> queries could get really clunky that way, so perhaps not.  Use your
> judgment.
> --Benjamin Gilbert
> _______________________________________________
> openslide-users mailing list
> openslide-users at lists.andrew.cmu.edu
> https://lists.andrew.cmu.edu/mailman/listinfo/openslide-users
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2012.0.2197 / Virus Database: 2437/5165 - Release Date: 07/30/12

More information about the openslide-users mailing list