IPv6

[ellie timoney]

Hi Sebastian,

> > Sebastian, is there anything you tried that *didn't* work, and if so,
> > what happened?
> 
> The only thing I tried that didn't work was to add a IPv6 listener and to 
> HUP the master process. The manpage for master reads (in my version):
> 
>        Cyrus-master rereads its configuration file when it receives a 
> hangup signal, SIGHUP.   Services  and
>        events  may be added, deleted or modified when the configuration 
> file is reread.  Any active services
>        removed from the configuration file will be allowed to run until 
> completion.
> 
> From that it isn't obvious that some class of changes to cyrus.conf 
> apparently require a restart of the service. 

I've been looking through master/master.c to see what it actually does,
and it looks like it matches this documentation.

It does have some commentary in reread_conf() about recycling services
that have not been removed nor were newly added, which almost sounds as
if it might have this sort of effect... except that, digging into
add_service(), it will only reuse entries if their name, listen and
proto all match (which if you've changed one to IPv6, it won't), and
otherwise it will be added as a new service (and so reread_conf() will
treat it as a newly added service, not an existing one to recycle).

I'm pretty tired, and so probably not reading it as closely as I could
otherwise -- maybe there's a bug or subtlety I've missed -- but: it at
least /looks like it intends to/ do what the documentation says.  So
it's interesting that it didn't.

Cheers,

ellie

On Tue, Mar 29, 2016, at 11:45 PM, Sebastian Hagedorn wrote:
> Hi Ellie,
> 
> --On 29. März 2016 um 12:30:34 +1100 ellie timoney <ellie at fastmail.com> 
> wrote:
> 
> >> Ellie, can you please fix the listen statement to accept correctly
> >> bracketed ipv6 and backport to at least 2.5 and 2.4, shouldn't be many
> >> changes in that code.
> >
> > I don't think there's anything to fix here.  The code looks fine as is,
> > just docs missing.  Unless we want to explicitly *not* accepted
> > un-bracketed "ip6-address ':' port"?  But forbidding that seems silly,
> > considering it requires adding code to remove functionality.
> 
> I agree.
> 
> > This code hasn't changed since 2012, when it was refactored by 306099b.
> > It's in the same state (modulo tabs/spaces change) on 2.5 and master
> > branches.  The 2.4 version is significantly different, as it didn't get
> > the refactor (but that doesn't appear to be a problem here).
> >
> > I'm scouring the thread trying to figure out if there's even a problem
> > being reported (other than lack of docs) and I can't see it.  It seems
> > to have gone like:
> >
> >     Sebastian: How do I do this?
> >     Various: It's not in docs, but try this...
> >     Sebastian: I tried this and it worked
> >
> > Sebastian, is there anything you tried that *didn't* work, and if so,
> > what happened?
> 
> The only thing I tried that didn't work was to add a IPv6 listener and to 
> HUP the master process. The manpage for master reads (in my version):
> 
>        Cyrus-master rereads its configuration file when it receives a 
> hangup signal, SIGHUP.   Services  and
>        events  may be added, deleted or modified when the configuration 
> file is reread.  Any active services
>        removed from the configuration file will be allowed to run until 
> completion.
> 
> From that it isn't obvious that some class of changes to cyrus.conf 
> apparently require a restart of the service. So I'm mainly asking for 
> documentation fixes:
> 
> • clarify the allowed IPv6 address formats
> • clarify that SIGHUP isn't enough for all (which?) config changes
> 
> Thanks, Sebastian´
> -- 
>     .:.Sebastian Hagedorn - Weyertal 121 (Gebäude 133), Zimmer 2.02.:.
>                  .:.Regionales Rechenzentrum (RRZK).:.
>    .:.Universität zu Köln / Cologne University - ✆ +49-221-470-89578.:.
> Email had 1 attachment:
> + Attachment2
>   1k (application/pgp-signature)