"struct et_list" declared inside parameter list - possible cleanup?

[Rosenbaum, Larry M.]

I think I found the problem.  The "struct et_list" is defined in et/error_table.h, but this file is not #included in imapd.c, imap_err.h, or any of the other *_err.h files, which means the structure in the initialize_imap_error_table_r() function prototype is undefined.  (This is also true for some other files, not just imapd.c)  Does this file need to be #included somewhere?

Thanks, Larry

________________________________________
From: info-cyrus-bounces at lists.andrew.cmu.edu [mailto:info-cyrus-bounces at lists.andrew.cmu.edu] On Behalf Of Rosenbaum, Larry M.
Sent: Wednesday, July 12, 2006 11:02 AM
To: info-cyrus at lists.andrew.cmu.edu
Subject: "struct et_list" declared inside parameter list - possible cleanup?

Would it be possible to eliminate the following compiler warnings?

In file included from imapd.c:75:
imap_err.h:67: warning: "struct et_list" declared inside parameter list
imap_err.h:67: warning: its scope is only this definition or declaration, which is probably not what you want

It appears to be harmless, but it would be nice to have a completely clean compile.

I am using gcc 3.4.2 on Solaris 8 and Solaris 9.  I have seen this warning on all Cyrus IMAP v2.3.x.

Larry