idled too fast?

[Ken Murchison]

Quoting Luc Germain <luc.germain at usherbrooke.ca>:

> Yes it solved the problem! Great.
> 
> Will this patch be included in the next release?

Yes (don't know what/when it will be).  I'll commit it soon.


> 
> Thanks.
> 
> Luc.
> --
> Luc Germain, analyste
> Support technique
> Service des technologies de l'information
> Université de Sherbrooke, Sherbrooke (Québec) Canada  J1K 2R1
> tel: 819-821-8000 ext 2866    fax: 819-821-8045
> email: Luc.Germain at USherbrooke.ca
> 
> 
> -----Message d'origine-----
> De : Ken Murchison [mailto:ken at oceana.com]
> Envoyé : 27 août 2002 17:17
> À : Luc Germain
> Cc : info-cyrus at lists.andrew.cmu.edu
> Objet : Re: idled too fast?
> 
> 
> 
> 
> Luc Germain wrote:
> >
> > Hi,
> >
> > I'm testing cyrus imapd 2.1.7 on a Pentium-3 1.4 GHz system running
> redhat
> > 7.3. I have compiled with idled activated.
> >
> > When using Outlook 2000 on Win98SE as a client, Outlook never see the
> latest
> > mail arrived in the inbox folder. I monitored the inbox folder content
> (from
> > the command prompt) and the log in /var/imap/log, and when a new mail
> > arrive, the IDLE command stop and warn that new mail is available. Then
> > Outlook immediatly ask for all the new mail (UID FETCH 115:*) but cyrus
> does
> > not list the last one that just arrived (UID 116).
> >
> > I'm guessing that the IDLE command warns the client too soon, before the
> > last message is really included in the cyrus.index file so Outlook does
> not
> > see it.
> >
> > Is it possible? If so, is it possible to change IDLED so it warns the
> client
> > only after the mail is really delivered? (Or at least add a small delay
> to
> > IDLED)
> >
> > Note that I didn't see that problem when testing cyrus imapd 2.1.4 on a
> > Pentium 3 1.2 GHz system running redhat 7.2
> >
> > Thanks for any help with this.
> 
> 
> Try this patch and see if it makes a difference.
> 
> 
> Index: mailbox.c
> ===================================================================
> RCS file: /afs/andrew/system/cvs/src/cyrus/imap/mailbox.c,v
> retrieving revision 1.136
> diff -u -c -r1.136 mailbox.c
> cvs server: conflicting specifications of output style
> *** mailbox.c	2002/08/23 17:59:25	1.136
> --- mailbox.c	2002/08/27 21:12:49
> ***************
> *** 1162,1169 ****
> 
>       assert(mailbox->index_lock_count != 0);
> 
> -     if (updatenotifier) updatenotifier(mailbox);
> -
>   #if 0
>       if (acappush_sock != -1) {
>   	acapmbdata_t acapdata;
> --- 1162,1167 ----
> ***************
> *** 1212,1217 ****
> --- 1210,1217 ----
>   	/* xxx can we unroll the acap send??? */
>   	return IMAP_IOERROR;
>       }
> +
> +     if (updatenotifier) updatenotifier(mailbox);
> 
>       return 0;
>   }
> 
> --
> Kenneth Murchison     Oceana Matrix Ltd.
> Software Engineer     21 Princeton Place
> 716-662-8973 x26      Orchard Park, NY 14127
> --PGP Public Key--    http://www.oceana.com/~ken/ksm.pgp
> 
> 
> 
> 


-- 
Kenneth Murchison     Oceana Matrix Ltd.
Software Engineer     21 Princeton Place
716-662-8973 x26      Orchard Park, NY 14127
--PGP Public Key--    http://www.oceana.com/~ken/ksm.pgp