problem in configure with event-notification disabled

[Anatoli]

Hi Ellie,

 

Thanks for the information. Forgot to mention, yes, the version we're testing is the latest release: 2.5.7.

 

Talking about master (I suppose you mean the v3.0), is there any ETA for the 3.0 release? How close to production-ready is the current state of beta1/master? It looks like the v3.0 has implemented a number of interesting features, it would be great to see the release soon! : )

 

Regards,

Anatoli

 

From: Cyrus-devel [mailto:cyrus-devel-bounces+me=anatoli.ws at lists.andrew.cmu.edu] On Behalf Of ellie timoney via Cyrus-devel
Sent: Friday, April 08, 2016 02:44
To: cyrus-devel at lists.andrew.cmu.edu
Subject: Re: problem in configure with event-notification disabled

 

Hi Anatoli,

 

We've experimented with different configure options and found that when --disable-event-notification option is enabled, the configure script fails for other options with something like:

configure: error: Need libxml-2.0 for http

After some analysis we found that the dependencies detection initialization logic is placed inside the condition of event-notification option, so when it's disabled, the initialization is not performed and the detection of libraries/dependencies fails. 

With this email I attach a simple patch that places the event-notification condition after the libraries detection initialization logic.

 

Well spotted, thanks!  I assume you're using Cyrus 2.5.x?

 

configure is generated by autoconf from configure.ac, so the correct place to fix this is in configure.ac, at least on-going.

 

It looks like the problem is due to the PKG_CHECK_MODULES macro first being invoked inside a bash conditional.  The problem, and its fix, is discussed in section 3.4 here: https://autotools.io/pkgconfig/pkg_check_modules.html

 

And, it looks like it's already fixed on master, so I'll backport the fix to the 2.5 branch, and it will be included in the next release.

 

I would like to seize the opportunity and ask you for a clarification.. Does the event notification component make any sense under normal use conditions (IMAP with email clients like Thunderbird and Outlook)? If I understand it correctly, it's only needed for some special types of notifications like for xmpp clients, debugging and similar, not for something implemented in normal IMAP clients, so it makes sense to disable it for production use. Am I right?

 

I don't know much about it myself -- can someone else field this question please?

 

Cheers,

 

ellie

 

On Fri, Apr 8, 2016, at 02:48 PM, Anatoli via Cyrus-devel wrote:

Hi all,

 

Firstly, thanks, developers, for your hard work in creating Cyrus! We've deployed it recently and it worked as expected from the first try (after reading a lot of documentation first :).

 

We've experimented with different configure options and found that when --disable-event-notification option is enabled, the configure script fails for other options with something like:

 

configure: error: Need libxml-2.0 for http

 

After some analysis we found that the dependencies detection initialization logic is placed inside the condition of event-notification option, so when it's disabled, the initialization is not performed and the detection of libraries/dependencies fails.

 

With this email I attach a simple patch that places the event-notification condition after the libraries detection initialization logic.

 

 

I would like to seize the opportunity and ask you for a clarification.. Does the event notification component make any sense under normal use conditions (IMAP with email clients like Thunderbird and Outlook)? If I understand it correctly, it's only needed for some special types of notifications like for xmpp clients, debugging and similar, not for something implemented in normal IMAP clients, so it makes sense to disable it for production use. Am I right?

 

Thanks,

Anatoli

Email had 1 attachment:

*	configure.patch

  1k (text/plain)

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20160408/9eac2d66/attachment.html>