SEGFAULT in reconstruct (2.5.5)

[Marty Lee]

When using ‘reconstruct’ to upgrade the database formats from 2.4.17-caldav-b10 -> 2.5.5,
‘reconstruct' core dumps (Solaris 10, Sun Studio C Compiler).

Looking at the code, it seems that if there is an error with ‘mailbox_reconstruct’
and the error isn’t IMAP_IOERROR, a ‘NULL’ is sent to com_err as the string arg.
I’ve updated the ‘NULL’ to a more meaningful (if possibly unhelpful) message, and this
then manages to at least get through all of the mailboxes now, rather than just a
partial update.

Patch:

*** imap/reconstruct.c.orig     Sun Aug 23 08:48:52 2015
--- imap/reconstruct.c  Sun Aug 23 09:27:32 2015
***************
*** 465,471 ****
      r = mailbox_reconstruct(lastname, reconstruct_flags);
      if (r) {
        com_err(lastname, r, "%s",
!               (r == IMAP_IOERROR) ? error_message(errno) : NULL);
        return 0;
      }

--- 465,471 ----
      r = mailbox_reconstruct(lastname, reconstruct_flags);
      if (r) {
        com_err(lastname, r, "%s",
!               (r == IMAP_IOERROR) ? error_message(errno) : "Failed to reconstruct mailbox");
        return 0;
      }



That’s the bug - the error is something to do with an sqlite table I’m guessing,
as it was doing something with my calendar when it core dumped. Error in the
system logs is:

Aug 23 09:34:51 coll https[24456]: [ID 327283 local6.error] dav_exec() prepare: table ical_objs has no column named comp_flags
Aug 23 09:34:51 coll https[24456]: [ID 846116 local6.error] append_fromstage() failed
Aug 23 09:34:52 coll https[24462]: [ID 327283 local6.error] dav_exec() prepare: no such column: comp_flags


Guess there something else I need to upgrade/run when moving from 2.4.17-caldav-b10 to 2.5.5.. Anyone have any ideas? (google on the errors provided no responses)


-----
Marty Lee                         e: marty at maui-systems.co.uk
Technical Director                v: +44 845 869 2661
Maui Systems Ltd                  f: +44 871 433 8922
Scotland, UK                      w: http://www.maui-systems.co.uk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20150823/bf86989f/attachment.bin