Large Mailbox Append Fix
brong at fastmail.fm
Fri Sep 21 22:55:22 EDT 2007
On Fri, Sep 21, 2007 at 06:35:11PM +0100, David Carter wrote:
> On Fri, 21 Sep 2007, Ken Murchison wrote:
>> What happens if the total number of messages to upload is a multiple of
>> max_count? Our last batch will be handled inside of the for() loop, and
>> then we'll call index_list_work() with an empty list, correct?
> Yes. The final index_list_work() would be a NOOP in that case. Could always
> add the (index_list->count == 0) test to upload_messages_list() and
> upload_messages_from() as well.
We still need to sync the final last_uid, which may be greater than
the UID of the maximum message.
(though I think there's a separate check later that does that if they
still don't match... I really should test-case this!)
More information about the Cyrus-devel