reconstruct should not destroy a readable cyrus.expunge.

[Ken Murchison]

Wesley Craig wrote:
> On 08 Aug 2006, at 12:59, Ken Murchison wrote:
>> Paul Turgyan wrote:
>>> I can see where you want reconstruct to correct all problems with a 
>>> mailbox,
>>> but after validating cyrus.expunge why not just let it be,  and let 
>>> cyr_expire handle
>>> the deletion.  This way, as you said, a user can unexpunge those 
>>> messages if he wants.
>>
>> I can't say that I disagree with you.  I have this eerie feeling that 
>> there is a reason that I chose to delete the expunged messages.  Maybe 
>> the Fastmail guys can remember.
> 
> This is what I found on the subject:
> 
>     https://bugzilla.andrew.cmu.edu/show_bug.cgi?id=2412
> 
> Just to be clear, if we're in agreement on how reconstruct should work, 

Are we in agreement?  Paul's patch (bug #2866) actually unexpunges the 
messages.  I thought that folks we arguing that cyrus.expunge and the 
references messages should be left alone and omitted from cyrus.index.


> then we will submit a patch.  We're also having issues with non-unique 
> mailbox IDs.  I'd like reconstruct to detect non-unique mailbox IDs and 
> assign new mailbox IDs as appropriate.  Any comments on that?

Sounds reasonable.

-- 
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University