cyr_expire bug with misconfigured metapartition

[Andrew Morgan]

I have been bringing up some new Cyrus backends in my Murder cluster 
lately, and I stumbled across a bug of sorts in cyr_expire.  I had a 
slightly wrong imapd.conf with respect to metapartitions, which said:

   defaultpartition: p1
   partition-p1: /var/spool/cyrus/mail/data1
   metap1: /var/spool/cyrus/mail/meta1
   partition-p2: /var/spool/cyrus/mail/data2
   metap2: /var/spool/cyrus/mail/meta2
   metapartition_files: index cache expunge squat

Obviously, the correct config should have been:

   defaultpartition: p1
   partition-p1: /var/spool/cyrus/mail/data1
   metapartition-p1: /var/spool/cyrus/mail/meta1
   partition-p2: /var/spool/cyrus/mail/data2
   metapartition-p2: /var/spool/cyrus/mail/meta2
   metapartition_files: index cache expunge squat

The only reason I discovered this was wrong was that my cyr_expire command 
refused to expire expunged messages and mailboxes, and didn't honor 
"expire" annotations.  I'm running delayed expunge and delayed delete.

Once I fixed the config, cyr_expire began behaving normally again.

Why did this happen?

 	Andy