Stripping ALL tabs from the code

[Nic Bernstein]

On 06/14/2015 07:48 PM, Bron Gondwana wrote:
> On Tue, Jun 9, 2015, at 08:42 PM, Bron Gondwana wrote:
>> The big news from yesterday's meeting is that we are going to check in a single massive commit which strips all leading tabs from the code, everywhere.  The new coding standard is 4 spaces for each level of indent, and spaces for all alignment within code as well.
>>
>> I've pushed a small perl script to master which performs the necessary surgery.  it has the smarts to know when a tab isn't on a multiple-of-8 boundary and substitute fewer spaces.
>>
>> The code still builds and passes tests afterwards, so I'm pretty sure it's good.
>>
>> I will be running the on master on June 14th (Sunday) night Melbourne time.  That's weekend for everyone, everywhere in the world.  I will immediately push the result back to master (after running the tests again of course).
>>
>> If you have a patch series lying around that you want to apply, it might be a good idea to do it before then!  Alternatively, you can patch with -l or --ignore-whitespace to apply your patches to the tree, and then run tools/remove-tabs.pl on the resulting tree to remove the tabs again.
>>
>> Enjoy your new, simpler coding style with no trailing whitespace left!
> This has been done - I didn't quite finish the instructions last night, so I did the work this morning.

Bron,
Maybe I'm doing something wrong here, but this morning I figured I'd 
start over clean, so deleted my existing cyrus-docs checkout and grabbed 
a new one:
     $ git clone ssh://git@git.cyrus.foundation/diffusion/I/cyrus-docs.git

What I ended up with looked suspiciously like the cyrus-imapd tree. So I 
checked that by doing a diff of the two:

    $ diff -Nuwb cyrus-docs cyrus-imapd
    Common subdirectories: cyrus-docs/cmulocal and cyrus-imapd/cmulocal
    Common subdirectories: cyrus-docs/com_err and cyrus-imapd/com_err
    Common subdirectories: cyrus-docs/contrib and cyrus-imapd/contrib
    Common subdirectories: cyrus-docs/cunit and cyrus-imapd/cunit
    Common subdirectories: cyrus-docs/depot and cyrus-imapd/depot
    Common subdirectories: cyrus-docs/doc and cyrus-imapd/doc
    Common subdirectories: cyrus-docs/.git and cyrus-imapd/.git
    Common subdirectories: cyrus-docs/imap and cyrus-imapd/imap
    Common subdirectories: cyrus-docs/imtest and cyrus-imapd/imtest
    Common subdirectories: cyrus-docs/lib and cyrus-imapd/lib
    Common subdirectories: cyrus-docs/man and cyrus-imapd/man
    Common subdirectories: cyrus-docs/master and cyrus-imapd/master
    Common subdirectories: cyrus-docs/netnews and cyrus-imapd/netnews
    Common subdirectories: cyrus-docs/notifyd and cyrus-imapd/notifyd
    Common subdirectories: cyrus-docs/perl and cyrus-imapd/perl
    Common subdirectories: cyrus-docs/ptclient and cyrus-imapd/ptclient
    Common subdirectories: cyrus-docs/sieve and cyrus-imapd/sieve
    Common subdirectories: cyrus-docs/snmp and cyrus-imapd/snmp
    Common subdirectories: cyrus-docs/timsieved and cyrus-imapd/timsieved
    Common subdirectories: cyrus-docs/tools and cyrus-imapd/tools

Could something have gone awry with this whitespace cleanup?

Concerned,
     -nic

-- 
Nic Bernstein                             nic at onlight.com
Onlight, Inc.                             www.onlight.com
1442 N Farwell Ave., Suite 600            v. 414.272.4477
Milwaukee, Wisconsin  53202

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20150615/2fb70f2d/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nic.vcf
Type: text/x-vcard
Size: 271 bytes
Desc: not available
Url : http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20150615/2fb70f2d/attachment.vcf