<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 06/14/2015 07:48 PM, Bron Gondwana wrote:<br>
<blockquote
cite="mid:1434329327.199214.295424153.45D66F6C@webmail.messagingengine.com"
type="cite">
<pre wrap="">On Tue, Jun 9, 2015, at 08:42 PM, Bron Gondwana wrote:
</pre>
<blockquote type="cite">
<pre wrap="">The big news from yesterday's meeting is that we are going to check in a single massive commit which strips all leading tabs from the code, everywhere. The new coding standard is 4 spaces for each level of indent, and spaces for all alignment within code as well.
I've pushed a small perl script to master which performs the necessary surgery. it has the smarts to know when a tab isn't on a multiple-of-8 boundary and substitute fewer spaces.
The code still builds and passes tests afterwards, so I'm pretty sure it's good.
I will be running the on master on June 14th (Sunday) night Melbourne time. That's weekend for everyone, everywhere in the world. I will immediately push the result back to master (after running the tests again of course).
If you have a patch series lying around that you want to apply, it might be a good idea to do it before then! Alternatively, you can patch with -l or --ignore-whitespace to apply your patches to the tree, and then run tools/remove-tabs.pl on the resulting tree to remove the tabs again.
Enjoy your new, simpler coding style with no trailing whitespace left!
</pre>
</blockquote>
<pre wrap="">
This has been done - I didn't quite finish the instructions last night, so I did the work this morning.
</pre>
</blockquote>
<br>
Bron,<br>
Maybe I'm doing something wrong here, but this morning I figured I'd
start over clean, so deleted my existing cyrus-docs checkout and
grabbed a new one:<br>
$ git clone
<a class="moz-txt-link-abbreviated" href="mailto:ssh://git@git.cyrus.foundation/diffusion/I/cyrus-docs.git">ssh://git@git.cyrus.foundation/diffusion/I/cyrus-docs.git</a><br>
<br>
What I ended up with looked suspiciously like the cyrus-imapd tree.
So I checked that by doing a diff of the two:<br>
<blockquote>$ diff -Nuwb cyrus-docs cyrus-imapd<br>
Common subdirectories: cyrus-docs/cmulocal and
cyrus-imapd/cmulocal<br>
Common subdirectories: cyrus-docs/com_err and cyrus-imapd/com_err<br>
Common subdirectories: cyrus-docs/contrib and cyrus-imapd/contrib<br>
Common subdirectories: cyrus-docs/cunit and cyrus-imapd/cunit<br>
Common subdirectories: cyrus-docs/depot and cyrus-imapd/depot<br>
Common subdirectories: cyrus-docs/doc and cyrus-imapd/doc<br>
Common subdirectories: cyrus-docs/.git and cyrus-imapd/.git<br>
Common subdirectories: cyrus-docs/imap and cyrus-imapd/imap<br>
Common subdirectories: cyrus-docs/imtest and cyrus-imapd/imtest<br>
Common subdirectories: cyrus-docs/lib and cyrus-imapd/lib<br>
Common subdirectories: cyrus-docs/man and cyrus-imapd/man<br>
Common subdirectories: cyrus-docs/master and cyrus-imapd/master<br>
Common subdirectories: cyrus-docs/netnews and cyrus-imapd/netnews<br>
Common subdirectories: cyrus-docs/notifyd and cyrus-imapd/notifyd<br>
Common subdirectories: cyrus-docs/perl and cyrus-imapd/perl<br>
Common subdirectories: cyrus-docs/ptclient and
cyrus-imapd/ptclient<br>
Common subdirectories: cyrus-docs/sieve and cyrus-imapd/sieve<br>
Common subdirectories: cyrus-docs/snmp and cyrus-imapd/snmp<br>
Common subdirectories: cyrus-docs/timsieved and
cyrus-imapd/timsieved<br>
Common subdirectories: cyrus-docs/tools and cyrus-imapd/tools<br>
</blockquote>
Could something have gone awry with this whitespace cleanup?<br>
<br>
Concerned,<br>
-nic<br>
<pre class="moz-signature" cols="72">--
Nic Bernstein <a class="moz-txt-link-abbreviated" href="mailto:nic@onlight.com">nic@onlight.com</a>
Onlight, Inc. <a class="moz-txt-link-abbreviated" href="http://www.onlight.com">www.onlight.com</a>
1442 N Farwell Ave., Suite 600 v. 414.272.4477
Milwaukee, Wisconsin 53202
</pre>
</body>
</html>