cyrus 2.4.16, duplicate suppression = false and sieve redirects

[Bron Gondwana]

On Thu, Aug 2, 2012, at 06:30 PM, Chris Stromsoe wrote:
> Setting duplicate suppression to false does not disable duplicate 
> suppression for sieve redirects in 2.4.16.
> 
> >From lmtp_sieve.c, starting line 378:
> 
>      /* if we have a msgid, we can track our redirects */
>      if (m->id) {
>          snprintf(buf, sizeof(buf), "%s-%s", m->id, rc->addr);
>          sievedb = make_sieve_db(sd->username);
> 
>          dkey.id = buf;
>          dkey.to = sievedb;
>          dkey.date = ((deliver_data_t *) mc)->m->date;
>          /* ok, let's see if we've redirected this message before */
>          if (duplicate_check(&dkey)) {
>              duplicate_log(&dkey, "redirect");
>              return SIEVE_OK;
>          }
>      }
> 
> 
> Is the missing check a bug or feature?

Pretty sure that's a feature - otherwise you wind up with infinite loop
goodness.

Bron.
-- 
  Bron Gondwana
  brong at fastmail.fm