Coding standards / spaces vs tabs

Bron Gondwana brong at fastmail.fm
Wed Oct 20 22:49:58 EDT 2010


On Thu, Oct 21, 2010 at 01:05:04PM +1100, Bron Gondwana wrote:
> commit 6a9be341d3de4cff9f548bfb0c26546f1a4b2605
>     Also, remove the mixed use of tabs and spaces (I used 4 spaces to a tab) and indent accordingly for t
> 
> Now I happen to think this is approximately one of the
> shittiest coding standards ever - but unless we all
> agree to change it, rewriting functions to use different
> indentation styles is counterproductive.

Futhermore, it makes the diff bloody hard to read, which is
a pain when your patch causes things like this:

upload failed: put script: script errors:
line 1: syntax error, unexpected $undefined

So I just committed a revert against it on my local tree
and my builds are happy again.

Bron.


More information about the Cyrus-devel mailing list