[PATCH] Characters allowed in folder names (#2633)

[Jeroen van Meeuwen (Kolab Systems)]

Bron Gondwana wrote:
> On Sat, Aug 07, 2010 at 07:22:05PM +0200, Jeroen van Meeuwen (Kolab Systems) 
wrote:
> >  Attached is 
> > a patch that shows how I would like this a configurable setting. Unless 
I'm 
> > mistaken, this should preserve the behavior presented today, but allows a 
> > 'goodchars' setting to be supplied in imapd.conf.
> 
> While I like tunables, I don't like this approach.  The problem is, the
> default sucks.  I'd prefer to see ALL possible good characters in the
> source, and the option of setting additional characters you won't allow
> in the config file, so the default option is best for most people.
> 

There can never be enough tunables ;-) This one indeed doesn't necessarily 
make sense.

That said, I recon there is no distinction between "normal" and "expert" 
settings in Cyrus IMAP. Meaning, that if something is made configurable at 
all, it'll be thrown at the user, in the man page, and throughout the 
documentation.

I usually have the following distinction in types of settings in some 
applications;

- "Novice" settings in the GUI - just gets the job done, click through, 
nothing to see here.

- "Advanced" settings on the CLI - gets *your* job done. If you know what 
you're doing.

- "Expert" settings - you're on your own.

This setting, I think, is a typical "you're on your own" type of setting. 
While I think it should be configurable, I dislike throwing it in the man 
page. I would argue this type of thing is way better documented on a 
cyrusimap.org Wiki article.

> Cyrus already has too many configuration options for most sites to cope
> with.  Adding more sucks.
> 
> (also on a technical note: I would put the default in lib/imapoptions
> rather than testing if the config value existed)
> 

I tried, but the way lib/imapoptions is being parsed by some custom scripts in 
tools made it not work; it would split up the default string at the ',' for 
some reason I could not determine just like that.

-- 
Jeroen van Meeuwen
Senior Engineer, Kolab Systems AG

e: vanmeeuwen at kolabsys.com
t: +316 42 801 403
w: http://www.kolabsys.com

pgp: 9342 BF08