[PATCH] Characters allowed in folder names (#2633)

[Bron Gondwana]

On Sat, Aug 07, 2010 at 07:22:05PM +0200, Jeroen van Meeuwen (Kolab Systems) wrote:
> Hi there,
> 
> Current Kolab packages ship a patch to allow more character names in IMAP 
> mailbox/folder names then is currently permitted with the characters listed in 
> imap/mboxname.c:724 GOODCHARS definition. Bug #2633[1] also concerns this 
> topic.
> 
> In an attempt to do a little research on the set of characters allowed in a 
> mailbox, I stumbled upon section 5.1 in RFC 3501[2]. Sub-section 5.1.3 
> confuses me a little, so I hope some of you can shed some light on that if 
> necessary.
> 
> It seems that mailbox/folder names may contain any of the characters in 7-bit 
> ASCII, but GOODCHARS does not have all of those characters listed. Attached is 
> a patch that shows how I would like this a configurable setting. Unless I'm 
> mistaken, this should preserve the behavior presented today, but allows a 
> 'goodchars' setting to be supplied in imapd.conf.

While I like tunables, I don't like this approach.  The problem is, the
default sucks.  I'd prefer to see ALL possible good characters in the
source, and the option of setting additional characters you won't allow
in the config file, so the default option is best for most people.

Cyrus already has too many configuration options for most sites to cope
with.  Adding more sucks.

(also on a technical note: I would put the default in lib/imapoptions
rather than testing if the config value existed)

Bron.