some cleanups and fixes for Cyrus IMAPd....

[Bron Gondwana]

On Mon, Jul 14, 2008 at 05:09:27PM -0400, Greg A. Woods wrote:
> Here's a whack of cleanups and fixes for Cyrus IMAPd.  Many I would
> consider absolutely critical while some are simply helpful and others
> are just to shut up the compiler.  I may have posted this before, but
> here it is again, updated to match the head of the CVS trunk today.

One thing I find very helpful at FastMail doing similar things is to
follow the Linux kernel approach to this sort of patch - factor your
changes into discrete "fixes" that you can apply in order, but each
of which is reviewable as a discrete unit.

Obviously, some changes may depend on other changes, but often it means
that your patches can be "cherry-picked" to apply the obvious fixes
without needing to accept everything at once.

I use 'quilt', which is fantastic at dealing with multiple separate
patches.  In fact, our cyrus build process involves fetching the
latest tarball (if not already cached on disk), checking out the
quilt tree from our local subversion, applying the patches in the
series file, running the build script on the result.

Other than that - no comments on the patch set (yet) - it's a big
read all in one blob!

Bron.