Large Mailbox Append Fix

Bron Gondwana brong at
Fri Sep 21 06:03:45 EDT 2007

On Fri, 21 Sep 2007 10:29:45 +0100 (BST), "David Carter" <dpc22 at> said:
> On Fri, 21 Sep 2007, Bron Gondwana wrote:
> > Attached is a patch that does both of these :)  It's possible that I haven't
> > done code-path coverage in my limited testing (it's on our test machine) so
> > a bit of review is probably in order!
> I think that:
>      if (index_list->count == 0) {
>          sync_index_list_free(&index_list);
>          return(r);
>      }

Bah, you're right - I missed one.  Maybe I should review my own code too...

> Otherwise looks good. Nice work.

Thanks :)

I swear I don't know why I'm working in "portable machine code"[tm] some of
these days.  You spend so long doing janitorial work!

(but then, I get annoyed enough at the amount of repeat code I have to write
 in Perl too - one day I'll find the time to work in a _nice_ language and/or
  Bron Gondwana
  brong at

More information about the Cyrus-devel mailing list