Large Mailbox Append Fix

David Carter dpc22 at cam.ac.uk
Fri Sep 21 05:29:45 EDT 2007


On Fri, 21 Sep 2007, Bron Gondwana wrote:

> Attached is a patch that does both of these :)  It's possible that I haven't
> done code-path coverage in my limited testing (it's on our test machine) so
> a bit of review is probably in order!

I think that:

     if (index_list->count == 0) {
         sync_index_list_free(&index_list);
         return(r);
     }

should just be:

     if (index_list->count == 0) {
         return(r);
     }

As I get an exciting:

*** glibc detected ***
   sync_client: double free or corruption (fasttop): 0x08134fd0 ***

Otherwise looks good. Nice work.

-- 
David Carter                             Email: David.Carter at ucs.cam.ac.uk
University Computing Service,            Phone: (01223) 334502
New Museums Site, Pembroke Street,       Fax:   (01223) 334679
Cambridge UK. CB2 3QH.


More information about the Cyrus-devel mailing list