Annotation replication with sync_client -u seems busted in 2.4.X

[ellie timoney]

Hi John,

This was already fixed in 2.5.0 and later [1], but a lot changed to enable it, so that fix was too invasive to backport.  

Your patch looks like a good solution for 2.4!  It's now on the cyrus-imapd-2.4 branch :)

Cheers,

ellie

[1] https://github.com/cyrusimap/cyrus-imapd/commit/f0aa1b38c46722c0203bd0d9630968872a3cda4c

On Wed, Mar 21, 2018, at 5:11 AM, John Capo wrote:
> Replicating annotations when sync_client -u is used to move mailboxes to 
> a different
> server does not work in 2.4.20 and probably not in 2.5.X either.  At 
> lest I can't find
> anyplace in the 2.5 code that replicates folder annotations.
> 
> Annotation replication does work in rolling replication mode.
> 
> Or have I busted it with other mods I make?
> 
> Patch attached that fixes it for me.
> 
> John Capo
> ----
> Cyrus Home Page: http://www.cyrusimap.org/
> List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
> To Unsubscribe:
> https://lists.andrew.cmu.edu/mailman/listinfo/info-cyrus
> Email had 1 attachment:
> + sync_client.c-patch
>   1k (application/octet-stream)