2.5.9 build issues

[ellie timoney]

> > > > *) htmlstrip.c gets installed as source to /usr/lib/cyrus-imapd. It seems
> > > > it doesn't get compiled at all and the source gets installed instead.
> 
> That's weird. htmlstrip is a tool used in the build process only, it
> shouldn't get installed anywhere (nor should its source).  Will see if I
> can reproduce it and work out why it happens.

I can't reproduce this using either 2.5.8, 2.5.9, or the current
cyrus-imapd-2.5 from git.  The former two I testing using the released
distribution tarballs from cyrusimap.org/releases, and also the tagged
git sources.  I used the usual configure/make/make install procedure. 
In no case did I end up with a "htmlstrip.c" file existing anywhere on
my system other than the respective source directories.

Is it possible this file on your system is hanging around from some
earlier version?  Before it got moved to tools/, the htmlstrip.c file
used to live in doc/text/ -- the same directory as the plain text docs
that it was used to generate (from html sources).  It's entirely
plausible that some previous version would then install it along with
those docs.

On Mon, Aug 22, 2016, at 09:25 AM, ellie timoney via Info-cyrus wrote:
> > Isn't this already fixed on the 2.5 branch?
> 
> Yep, commit 8a41e54
> 
> As for this:
> 
> > > > *) htmlstrip.c gets installed as source to /usr/lib/cyrus-imapd. It seems
> > > > it doesn't get compiled at all and the source gets installed instead.
> 
> That's weird. htmlstrip is a tool used in the build process only, it
> shouldn't get installed anywhere (nor should its source).  Will see if I
> can reproduce it and work out why it happens.
> 
> Cheers,
> 
> ellie
> 
> On Mon, Aug 22, 2016, at 09:14 AM, ellie timoney via Info-cyrus wrote:
> > Isn't this already fixed on the 2.5 branch?
> >
> > On Mon, Aug 22, 2016, at 02:17 AM, Ken Murchison via Info-cyrus wrote:
> > > I'm guessing we should steal json_support.h from master and add it to
> > > the 2.5 branch.
> > >
> > >
> > > On 08/20/2016 10:40 AM, Wolfgang Breyha via Info-cyrus wrote:
> > > > After modifying my spec file from 2.5.8 to 2.5.9 I ended up with two new
> > > > issues:
> > > >
> > > > *) jcal.c can't be compiled with jansson < 2.7 (eg. every RHEL) because
> > > > json_boolean_value() is missing. I fixed it with:
> > > > -------------
> > > > --- cyrus-imapd-2.5.9/imap/jcal.h.orig	2016-08-20 16:20:52.049359274 +0200
> > > > +++ cyrus-imapd-2.5.9/imap/jcal.h	2016-08-20 16:21:03.719723892 +0200
> > > > @@ -50,6 +50,10 @@
> > > >
> > > >   #include "util.h"
> > > >
> > > > +#if (JANSSON_MINOR_VERSION < 7)
> > > > +#define json_boolean_value     json_is_true
> > > > +#endif
> > > > +
> > > >   extern char *icalcomponent_as_jcal_string(icalcomponent* comp);
> > > >   extern icalcomponent *jcal_string_as_icalcomponent(const char *str);
> > > >   extern const char *begin_jcal(struct buf *buf);
> > > > ------------
> > > >
> > > > *) htmlstrip.c gets installed as source to /usr/lib/cyrus-imapd. It seems
> > > > it doesn't get compiled at all and the source gets installed instead.
> > > >
> > > > Greetings, Wolfgang
> > >
> > > --
> > > Kenneth Murchison
> > > Principal Systems Software Engineer
> > > Carnegie Mellon University
> > >
> > > ----
> > > Cyrus Home Page: http://www.cyrusimap.org/
> > > List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
> > > To Unsubscribe:
> > > https://lists.andrew.cmu.edu/mailman/listinfo/info-cyrus
> > ----
> > Cyrus Home Page: http://www.cyrusimap.org/
> > List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
> > To Unsubscribe:
> > https://lists.andrew.cmu.edu/mailman/listinfo/info-cyrus
> ----
> Cyrus Home Page: http://www.cyrusimap.org/
> List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
> To Unsubscribe:
> https://lists.andrew.cmu.edu/mailman/listinfo/info-cyrus