sync_client errors out after 2.3.16 -> 2.5.9 upgrade

[ellie timoney]

On Tue, Aug 2, 2016, at 02:14 PM, Kenneth Marshall via Info-cyrus wrote:
> On Tue, Aug 02, 2016 at 12:34:13PM +1000, Bron Gondwana wrote:
> > 2.3.2 wasn't version 10, it was version 7!  It would have upgraded through 8, 9, 10 - and maybe you needed to reconstruct to get GUIDs for those versions - that sounds familiar.
> > 
> > Bron.
> > 
> 
> Hi Bron,
> 
> Is there a way to identify mailboxes with no GUID? Then I could target
> them
> for reconstruction first.
> 
> Regards,
> Ken

Hi Ken,

I don't suppose you still have mailboxes with no GUID?  Or have you
already found and "reconstruct -G"ed everything?

I've attached a patch that does two things, which are kind of the same
thing:

* If the mailbox on either end of the replication is of a version < 10,
then the operation will fail cleanly and early with an "Operation is not
supported on mailbox" error (rather than trying to do the replication,
then crashing out like it currently does) -- though I don't believe this
case will affect you, as I believe your mailboxes are all at least
version 10.

* If the mailbox on either end of the replication contains any index
records that do not have a GUID set, then the same will occur, and (in
addition to the above error) a warning will be logged to syslog like:
    <mailbox>: missing guid for record <number> -- needs 'reconstruct
    -G'?

So with this patch, you should be able to avoid these crashes, and also
identify mailboxes that need "reconstruct -G" just by checking for the
warning in syslog.

Are you able to try this out?

Cheers,

ellie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cyrus-imapd-2.5-dont-replicate-old-mailboxes.patch
Type: text/x-diff
Size: 6471 bytes
Desc: not available
URL: <http://lists.andrew.cmu.edu/pipermail/info-cyrus/attachments/20160810/8d09d2b0/attachment.bin>