Cyrus 2.4.7beta1 Released

[Rosenbaum, Larry M.]

> -----Original Message-----
> From: Bron Gondwana [mailto:brong at fastmail.fm]
> Sent: Tuesday, March 29, 2011 5:26 PM
> To: Rosenbaum, Larry M.
> Cc: 'Dave McMurtrie'; info-cyrus at lists.andrew.cmu.edu
> Subject: Re: Cyrus 2.4.7beta1 Released
> 
> On Tue, Mar 29, 2011 at 04:59:23PM -0400, Rosenbaum, Larry M. wrote:
> > > I think this is my fault.  I will have a look later tonight.
> >
> > Also, I'm getting the following warnings from the "make" command.  I
> don't
> > know if they're related to the problem:
> >
> >  --------------
> > imclient.c
> > imclient.c: In function `tls_start_clienttls':
> > imclient.c:1955: warning: assignment discards qualifiers from pointer
> target
> > type
> >
> > tls.c: In function `tls_start_servertls':
> > tls.c:990: warning: assignment discards qualifiers from pointer target
> type
> > tls.c: In function `tls_start_clienttls':
> > tls.c:1340: warning: assignment discards qualifiers from pointer target
> type
> 
> Well... I don't think that's fresh.  Did you get these with 2.4.6?
> This is 10+ year old code on those lines, referencing the TLS
> libraries.  It's possible they have switched to returning a const
> value, which would make sense.
> 
> They're all references to SSL_get_current_cipher.
> 
> (maybe I should rephrase my question... if you try compiling 2.4.6
> NOW with your currently installed ssl libraries, do you get these
> same warnings?  Line numbers may have changed slightly)

Yes, I got these warnings with 2.4.6 and 2.4.5.  I was too lazy to report it then. I didn't get the warnings with 2.3.15, but that was with an earlier version of OpenSSL.

> > (every link command has the following error)
> > ld: warning: global symbol `_END_' has non-global binding:
> >         (file /usr/local/ssl/lib/libssl.so value=LOCL);
> > ld: warning: global symbol `_START_' has non-global binding:
> >         (file /usr/local/ssl/lib/libssl.so value=LOCL);
> > ld: warning: global symbol `_END_' has non-global binding:
> >         (file /usr/local/ssl/lib/libcrypto.so value=LOCL);
> > ld: warning: global symbol `_START_' has non-global binding:
> >         (file /usr/local/ssl/lib/libcrypto.so value=LOCL);
> 
> I'll check them out too...   Those _END_ and _START_ issues are
> interesting.  Something about mixing 32 and 64 bit libs?
> 
> > IMAP.xs: In function `get_password':
> > IMAP.xs:206: warning: assignment makes pointer from integer without a
> cast
> 
> Are you sure you did a clean recompile?  This looks like IMAP.c didn't
> rebuild from IMAP.xs properly or something - it's assuming cyrus_getpass
> will return an int, when it doesn't.

I got this warning before I applied the patch you gave me.  When I reran the make after applying the patch, I didn't get this warning.

> Bron.