2.4.6 reconstruct: timestamp mismatch which doesn't go away
Simon Matter
simon.matter at invoca.ch
Thu Jan 20 06:26:26 EST 2011
> On Wed, Jan 19, 2011 at 11:00:00AM +0100, Simon Matter wrote:
>> Found it, sort of. The messages in question don't have any Received:
>> headers. They are in the Sent folder and old clients/servers didn't seem
>> to send Received: headers in that case.
>> Now, does it make sense to fall back to Date: header in that case to
>> determine internaldate?
>>
>> Something like this in message_create_record()?
>>
>> --- cyrus-imapd-2.4.6/imap/message.c.orig 2010-12-20
>> 14:15:49.000000000 +0100
>> +++ cyrus-imapd-2.4.6/imap/message.c 2011-01-19 10:51:57.000000000
>> +0100
>> @@ -570,6 +570,9 @@
>> if (body->received_date)
>> newdate = message_parse_date(body->received_date,
>> PARSE_DATE|PARSE_TIME|PARSE_ZONE|PARSE_NOCREATE|PARSE_GMT);
>> + else if (body->date)
>> + newdate = message_parse_date(body->date,
>> +
>> PARSE_DATE|PARSE_TIME|PARSE_ZONE|PARSE_NOCREATE|PARSE_GMT);
>> if (newdate)
>> record->internaldate = newdate;
>> }
>>
>>
>> This should apply only to locally copied messages (via IMAP) and
>> therefore
>> should be quite safe, is it?
>
> Hmm... absolutely. That should be good. I thought we did that already...
>
> As I'm telling everyone right now - can you create a bugzilla and tag it
> for 2.4.x. I'm busy moving at the moment - but I'll come back to this
> soon!
Thanks Bron, I found out why it fails but I don't know what the correct
fix would be.
See here http://bugzilla.cyrusimap.org/show_bug.cgi?id=3388
Regards,
Simon
More information about the Info-cyrus
mailing list