POLL: what should reconstruct -f do?

[Patrick Boutilier]

On 04/22/2011 08:07 PM, Bron Gondwana wrote:
> The question came up from the following bug report:
>
> http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449
>
> Where there were spool files on disk, but no meta data left.
> Reconstruct gave no information about the files on disk at
> all.
>
> I see 4 options, can I'd like some opinions on what people
> think reconstruct should do.  Speak now(ish) or hold your
> peace!
>
> 1) what we do now - require a cyrus.header in the directory
>     or ignore it.
>
> 2) like (1) but warn about the directory with no cyrus.header
>
> 3) add the mailbox if there's a directory, don't require
>     cyrus.header.
>
> 4) like (3) - but check that there's at least one cyrus.* file
>     OR at least one message file in the directory before
>     creating the mailbox.  (so an empty directory doesn't generate
>     a bogus mailbox, and neither does one containing nothing that
>     looks like it belongs in a mailbox)
>
>
> Alright, cast your votes!  I'll come back to this thread in a week
> or so and implement the winner.  (4) is the hardest to implement,
> but even that's not very tricky.
>
> Bron.
> ----
> Cyrus Home Page: http://www.cyrusimap.org/
> List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/



I like option 4 with option 3 as a second choice.