2.4.7 mailbox rename looses mail

[Wolfgang Breyha]

On 2011-04-05 22:27, Bron Gondwana wrote:
> I will test now with those configs, thanks Lucas.

It's an uninitialized return value! config doesn't matter IMO. It's pure
luck what r contains;-) If r != 0 the meta files are not copied and the
state of the mailbox is lost.
----------
--- cyrus-imapd-2.4.7/imap/mailbox.c.orig	2011-04-06 01:20:09.000000000 +0200
+++ cyrus-imapd-2.4.7/imap/mailbox.c	2011-04-06 01:17:01.000000000 +0200
@@ -2994,6 +2994,7 @@
     cyrus_mkdir(path, 0755);
     mkdir(path, 0755);

+    r = 0;
     /* Copy over meta files */
     for (mf = meta_files; !r && mf->metaflag; mf++) {
 	struct stat sbuf;
-----------

Regards, Wolfgang
-- 
Wolfgang Breyha <wbreyha at gmx.net> | http://www.blafasel.at/
Vienna University Computer Center | Austria