Cyrus IMAP Murder v2.4.2 MAILBOX-REFERRALS problem ?

[Bron Gondwana]

On Mon, Nov 22, 2010 at 10:48:28PM -0200, Lucas Zinato Carraro wrote:
> proxyd_allow_status_referral: 0

This is the default

> proxyd_disable_mailbox_referrals: 1

And it turns out this switch isn't hooked up to anything!

It doesn't disable anything at all.  There's no reference
anywhere in the code other than the bits that define it.

man/imapd.conf.5
792:.IP "\fBproxyd_disable_mailbox_referrals:\fR 0" 5

lib/imapoptions
933:{ "proxyd_disable_mailbox_referrals", 0, SWITCH }

lib/imapopts.c
530:  { IMAPOPT_PROXYD_DISABLE_MAILBOX_REFERRALS, "proxyd_disable_mailbox_referrals", 0, OPT_SWITCH,

lib/imapopts.h
169:  IMAPOPT_PROXYD_DISABLE_MAILBOX_REFERRALS,

In other words, it does nothing!  It got broken during the
copy of the 2.4 code over to master according to 'git blame',
so I'm going to CC Ken for his opinion on how this is supposed
to work.

Ken?

-    if (listargs->opts & LIST_REMOTE) {
-       if (!config_getswitch(IMAPOPT_PROXYD_DISABLE_MAILBOX_REFERRALS)) {
-           supports_referrals = !disable_referrals;
-       }
-    }
+    if (listargs->sel & LIST_SEL_REMOTE) supports_referrals = !disable_referrals;

That's the immediate block rewrite.

Bron.