Skiplist errors on Cyrus 2.3.12

[Bron Gondwana]

On Fri, Jul 11, 2008 at 11:37:52AM +0200, Reinhard Zierke wrote:
> Hi,
> 
> Since I upgraded my Solaris 10 Postfix/Cyrus mail server to Cyrus 2.3.12,
> I habe some problems when removing mailboxes.  I try to delete
> several users' mailboxes within one call of cyradm or in a homemade Perl
> script that uses Cyrus::IMAP::Admin.  The first delete in one command
> invocation always work fine, but from the second user on I get a terse
> error message "cyrus: c:" and the syslog shows something like:
> 
> Jul 11 10:32:41 mailhost.informatik.uni-hamburg.de cyradm[13944]: [ID 637875 local6.error] Fatal error: Internal error: assertion failed: cyrusdb_skiplist.c: 622: db->lock_status == UNLOCKED
> Jul 11 10:32:41 mailhost.informatik.uni-hamburg.de cyradm[13944]: [ID 558109 local6.error] skiplist: closed while still locked
> 
> Also, I see tons of skiplist 'already open' messages in my syslog like:
> 
> Jul 11 09:59:33 mailhost.informatik.uni-hamburg.de imaps[9792]: [ID 412576 local6.notice] skiplist: /var/imap/user/z/zierke.seen is already open 1 time, returning object
> 
> What's wrong?  And can I safely go back to Cyrus 2.3.11 binaries without
> botching up my Cyrus databases?

Oh yeah, a copy of your imapd.conf and whether you apply any patches
would be nice to know too.  Handy for reconstructing the problem!
I apply two patches to skiplists on 2.3.12 (yeah, I know, after all
the stuff I've had pushed upstream too):

hmm... and I realise I haven't updated the website for a while.
Doing that now... ok:

http://cyrus.brong.fastmail.fm/patches/cyrus-skiplist-safeunlock-2.3.12.diff
http://cyrus.brong.fastmail.fm/patches/cyrus-skiplist-readlocktracking-2.3.12.diff

I'd be interested to know if the issue still exists with these.
They tidy up the logic for locks even more.  I needed it to make
the fast_rename and folder_limit stuff work again.

Bron.