Cyrus IMAPd 2.3.12 Released

[Bron Gondwana]

On Wed, Apr 23, 2008 at 03:37:19PM +0400, Dmitriy Kirhlarov wrote:
> If dspam miss, user can manually move message from|to "spam" folder. This 
> fact fixed in cyrus log file. simple script parsing log and relaunch dspam.

> +    syslog(LOG_ERR, "DSPAM-Hack index_copysetup(): %s -> %s, hdr %s", mailbox->name,
> +	   copyargs->name, index_getheader(mailbox, msgno, "X-DSPAM-Signature"));

Wow - that's pretty tricky.  I see you're actually logging a specific
header as well.  Funky.  We don't have anything like that in our
auditlog patch.

I'd still suggest that this should be a generic mechanism rather than
a hard-coded header if it's going in upstream.  Something like

auditlog_headers: X-DSPAM-Signature X-Something-Else

which would cause a log line:

auditlog: copy oldmailbox=<user.foo.Bar> mailbox=<user.foo.Baz> olduid=<1234> uid=<7> guid=<478920478932fabed74398943243> x_dspam_signature=<something> x_something_else=<somethingelse>

Of course there would need to be quoting support since these headers
could contain <>.  Oh the humanity.  My favourite is URI encoding
because it's really quite simple to parse, but I'm sure everyone has
their favourite.

What do you think?

Bron.