64bit quota bug in 2.3.3?

[Ken Murchison]

Simon Matter wrote:
> As Sven Mueller pointed out, there appears to be a bug in the 64bit_quota
> patch I've included in my 2.2.x rpms. If I understand it correctly, the
> same issue applies to 2.3.3 too. Shouldn't the patch below go into 2.3.x?

Yes.  I found this bug myself in doing some testing of CONDSTORE code, 
and it was fixed in CVS on 3/30.



> --- cyrus-imapd-2.3.3/imap/mailbox.c.orig       2005-11-10
> 07:04:55.000000000 +0100
> +++ cyrus-imapd-2.3.3/imap/mailbox.c    2006-04-24 11:17:53.000000000 +0200
> @@ -920,10 +920,9 @@
>          mailbox->quota_mailbox_used =
>              ntohll(*((bit64
> *)(mailbox->index_base+OFFSET_QUOTA_MAILBOX_USED64)));
>      } else
> -#else
> +#endif
>      mailbox->quota_mailbox_used =
>         ntohl(*((bit32 *)(mailbox->index_base+OFFSET_QUOTA_MAILBOX_USED)));
> -#endif
> 
>      mailbox->pop3_last_login =
>         ntohl(*((bit32 *)(mailbox->index_base+OFFSET_POP3_LAST_LOGIN)));
> ----
> Cyrus Home Page: http://asg.web.cmu.edu/cyrus
> Cyrus Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
> List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html
> 


-- 
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University