bug: plugin log output, SASL_CB_LOG callback not used

[Johannes Stezenbach]

Hi,

I'm using mutt to connect to an Exchange server via IMAPS,
and the sasl library decides to use NTLM auth.  The
cyrus-sasl NTLM plugin then spams syslog LOG_AUTH:

Feb  9 14:04:12 zzz mutt: NTLM client step 1
Feb  9 14:04:12 zzz mutt: NTLM client step 2
Feb  9 14:04:12 zzz mutt: server flags: ff810205
Feb  9 14:04:12 zzz mutt: server domain: FOOBAR
Feb  9 14:04:12 zzz mutt: calculating NT response

Mutt passes a SASL_CB_LOG callback to sasl_client_init(),
to write log messages to the .muttdebug file.  After much searching
through the sasl sources I found mutt's callback is not used
because sasl/plugins/ntlm.c using utils->log(NULL, ...)
instead of utils->log(utils->conn, ...), so it uses
the default log callback instead of mutt's.

The same mistake seems to be repeated in other plugins, but
I did not look into it.  A quick test shows the messages end
up in .muttdebug with the s/NULL/utils->conn/ change.


Johannes