use valgrind / Re: SIGSEGV in cyrus-imapd 3.0.7 mupdate

[Дилян Палаузов]

Hello,

On Fri, 2018-07-13 at 10:40 +0200, Michael Menge wrote:
> 
> I have been running mupdate with STARTTLS for a few years with 2.3.x  
> and 2.4.x.
> It didn't crash as predictable as 3.0, but we had some instances where ...

The likely reason, why it hasn't crashеа as predictable is, that the
line DH_free(dh_params); was not part of cyrus-imapd-2.4  . It was
added to the caldav-2.4 branch back in 2014 and from there stayed in
the 3.0 and master branches.  Once a memory leak was found in 2017 on
the cyrus-imapd-2.5 branch, the line was added also there.  So for
fixing this on 2.5 it was a matter of having two persons find the
problem: one finds it and fixes it on caldav-2.4, and somebody else
finds it again on 2.5 two years later and arranges a fix there.

I thought everything from caldav-2.4 went into 2.5.  Now I see this was
not the case.

Please, as a rule, when fixing stuff on master (or caldav-2.4 in this
case), consider whether it is relevant also for the stable versions and
fix it there at the same time.  Postgres or Evolution are good
examples, how this process can be done.

Regards
  Дилян