[PATCH master] idled: Add missing signals_poll() call

ellie timoney ellie at fastmail.com
Sun Sep 27 21:56:51 EDT 2015


Hi Thomas,

This is now on master.  Thanks for the patch! :)

ellie

On Fri, Sep 25, 2015, at 06:39 PM, Thomas Jarosch wrote:
> This fixes broken shutdown on platforms without pselect().
> 
> A side effect of the "#ifdef HAVE_PSELECT" code path in signals_select()
> is that it calls signals_poll_mask() on each run. So it will
> pick up previously delivered signals.
> ---
>  imap/idled.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/imap/idled.c b/imap/idled.c
> index 065cde9..20b98e7 100644
> --- a/imap/idled.c
> +++ b/imap/idled.c
> @@ -339,6 +339,8 @@ int main(int argc, char **argv)
>      for (;;) {
>          int n;
>  
> +        signals_poll();
> +
>          /* check for shutdown file */
>          if (shutdown_file(NULL, 0)) {
>              /* signal all processes to shutdown */
> -- 
> 1.9.3
> 


More information about the Cyrus-devel mailing list