Patch RFC: Broken compilation with Sun CC, missing include statement

[Jens Erat]

Hi Marty,

have a look at the crash dump. If it is the same issue (within the same
library code), you should have a segfault with a non-zero pointer, that
occurs while parsing dates with US time zones. At least that's when we
had the issue.

I forgot one important information: obviously, this is only an issue if
you're compiling 64 bit binaries. 32 bit binaries will just be happy
with the 32 bit pointers.

Regards,
Jens

Am 17.09.2015 um 12:11 schrieb Marty Lee:
> Interesting; I've also got Cyrus crashing in the cal dav code on Solaris with studio compiler, just haven't had a chance to find out where and why.
> 
> Will keep this in mind when I have a look for it.
> 
> Marty
> 
>> On 17 Sep 2015, at 09:24, Jens Erat <jens.erat at uni-konstanz.de> wrote:
>>
>> Dear Cyrus maintainers,
>>
>>
>> building Cyrus IMAP 2.5.6 on Solaris 11 using the Sun CC, I experienced
>> issues when acting as replication target with the sync server crashing
>> for mails containing US timezones.
>>
>> After several hours of debugging, we traced it back to a missing include
>> statement in times.c (strings.h missing). This resulted in the Sun CC
>> falling back to some included function (thus compilation works), but
>> this one again is broken and returns 32 bit pointers instead of 64 bit
>> pointers in `strchr`.
>>
>> In the end, two problems add up here:
>>
>> - times.c trusting in strings.h already being included (which seemingly
>> is a false assumption considering the sync server)
>> - Sun CC probably being broken (we already issued a service request with
>> Oracle)
>>
>> I attached a proposed patch adding an include statement in times.c,
>> maybe it should be put somewhere further up in the include chain instead.
>>
>> Kind regards from Lake Constance, Germany,
>> Jens Erat
>>
>>
>> -- 
>> Jens Erat
>> Universität Konstanz
>> Kommunikations-, Infomations-, Medienzentrum (KIM)
>> Abteilung Basisdienste
>> D-78457 Konstanz
>> Mail: jens.erat at uni-konstanz.de
>> <cyrus-imapd-2.5.6-patch-times-include.patch>

-- 
Jens Erat
Universität Konstanz
Kommunikations-, Infomations-, Medienzentrum (KIM)
Abteilung Basisdienste
D-78457 Konstanz
Mail: jens.erat at uni-konstanz.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4893 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20150917/ba3396fd/attachment-0001.bin