Patch RFC: Fix broken builds with Sun CC

[Jens Erat]

Dear Cyrus-maintainers,

building Cyrus IMAP 2.5.6 on Solaris 11 using the Sun CC, I experienced
issues with some casts in `lib/imapopts.c`, an excerpt (similar lines
occurring hundreds of times):

"lib/imapopts.c", line 32: invalid cast expression
"lib/imapopts.c", line 32: non-constant initializer involving a cast
"lib/imapopts.c", line 33: invalid cast expression
"lib/imapopts.c", line 33: non-constant initializer involving a cast
"lib/imapopts.c", line 36: invalid cast expression
"lib/imapopts.c", line 36: non-constant initializer involving a cast
"lib/imapopts.c", line 37: invalid cast expression
"lib/imapopts.c", line 37: non-constant initializer involving a cast
"lib/imapopts.c", line 40: invalid cast expression
"lib/imapopts.c", line 41: invalid cast expression
"lib/imapopts.c", line 44: invalid cast expression
"lib/imapopts.c", line 45: invalid cast expression

This seems to have been reported multiple times by now [1] [2]. I
applied the proposed fix by Christos Soulios in [1] (removing
"GCCisms"), and it works fine for us.

I'm not sure whether this fix is a good or a bad idea, but these casts
aren't, either, breaking compatibility with other compilers.

Regards from Lake Constance, Germany,
Jens Erat

[1]: http://comments.gmane.org/gmane.mail.imap.cyrus/8927
[2]: http://lists.andrew.cmu.edu/pipermail/info-cyrus/2004-April/006894.html

-- 
Jens Erat
Universität Konstanz
Kommunikations-, Infomations-, Medienzentrum (KIM)
Abteilung Basisdienste
D-78457 Konstanz
Mail: jens.erat at uni-konstanz.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cyrus-imapd-2.5.6-patch-casts.patch
Type: text/x-patch
Size: 95284 bytes
Desc: not available
Url : http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20150915/ee1134f8/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4893 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20150915/ee1134f8/attachment-0003.bin