capitalized http service in 2.5.0 and FreeBSD

Paul Dekkers paul at sterrenkunde.nl
Wed Apr 1 15:13:07 EDT 2015


Hi,

I noticed that the pam-service for http in Cyrus 2.5.0 is capitalized,
while FreeBSD only accepts it lowercase:

saslauthd[96159]: in openpam_configure(): invalid service name
saslauthd[96159]: do_auth         : auth failure: [user=paul]
[service=HTTP] [realm=] [mech=pam] [reason=PAM start error]

So I had to change the 2 instances of sasl_server_new in httpd.c, I
attached the patch that I had to do.

Is there a good reason for having this service capitalized? The other
services are lowercase...

Regards,
Paul

P.S. I've send this to the info-cyrus list somewhere hidden in a larger
mail ;-) but I guess/hope this is the more appropriate list for this.


-------------- next part --------------
--- t/cyrus-imapd-2.5.0/imap/httpd.c	2015-03-03 13:09:17.000000000 +0100
+++ cyrus-imapd-2.5.0/imap/httpd.c	2015-03-18 19:24:12.000000000 +0100
@@ -560,7 +560,7 @@
     }

     /* other params should be filled in */
-    if (sasl_server_new("HTTP", config_servername, NULL, NULL, NULL, NULL,
+    if (sasl_server_new("http", config_servername, NULL, NULL, NULL, NULL,
 			SASL_USAGE_FLAGS, &httpd_saslconn) != SASL_OK)
 	fatal("SASL failed initializing: sasl_server_new()",EC_TEMPFAIL);

@@ -846,7 +846,7 @@

     sasl_dispose(conn);
     /* do initialization typical of service_main */
-    ret = sasl_server_new("HTTP", config_servername, NULL, NULL, NULL, NULL,
+    ret = sasl_server_new("http", config_servername, NULL, NULL, NULL, NULL,
 			  SASL_USAGE_FLAGS, conn);
     if(ret != SASL_OK) return ret;


More information about the Cyrus-devel mailing list