Build failed in Jenkins: cyrus-imapd-master #1059

[Дилян Палаузов]

Hello,

according to my logic,
1) at the end of ./configure a short summary of enabled and disabled 
options shall be printed (like murder, nntp, perl, com_err, etc), where 
the one who configures can see, that mboxevents are disabled, when 
janssion is not installed

2) it is up to that person to install jansson and reconfigure then.  If 
somebody can configure and install cyrus-imapd from source, then he can 
download, configure and install jansson.  Thus there is no reason to 
include jansson in the cyrus-imapd package.  (In the past a syslog 
variant was included in cyrus-imapd.tar but today it is assumed, that 
all systems have syslog.  At the same time the package for com_err is 
included in the cyrus-imapd tarball, however it is hard to find where to 
downloand and install com_err, which is not the case with jansson).  The 
documentation of cyrus-imapd (doc/install-configure.html) shall mention 
that the package depens on jansson and probably mention where jansson 
can be downloaded.  That's all.

3) if jansson is not installed, just "./configure" shall not hard-fail. 
  It shall disable implicitly the MBOXEVENT features, but ./configure 
shall complete its execution and disable event-notifications. 
"./configure" (in this form without parameters) is supposed to fail, if 
something absolutely necessary is missing, which is not the case for 
jansson.

4) "./configure --disable-event-notification" is useful only in the 
case, when jansson is installed on the system and cyrus-imapd shall be 
compiled without mbox events.

1) can be done later, and for the mentioned reasons I am against 
including the source of jansson in cyrus-imapd.

Greetings
   Дилян

On 08.01.2013 12:02, Sébastien Michel wrote:
> 2013/1/3 Bron Gondwana <brong at fastmail.fm>:
>>
>> I vote for using the technically best library.  It's probably small enough to that
>> we can ship it inside the Cyrus tarballs if we need.  It's only 132k in the src
>> directory of the latest jannson, and it's MIT licensed.
>
> 2013/1/4 Greg Banks <gnb at fastmail.fm>:
>>
>> As long as the feature gracefully disables itself if the library is not
>> installed at configure time, I'm really not fussed which library we use.
>>   For the CI server we'll probably need to build it manually, like a
>> whole bunch of other things.
>>
>
> If we choose to include the latest jansson sources in the Cyrus
> tarbal, It should be only if the jansson library is missing on the
> host server.
> In this case event notification may be always compiled and it will be
> possible to make some cleanup :
>   - removing test for event-notification in configure.ac
>   - removing ENABLE_MBOXEVENT C macro in some source files (imapd.c,
> pop3d.c, etc.)
>   - removing MBOXEVENT macro in Makefile.am
>
> preferences?
>
> Sébastien
>