Build failed in Jenkins: cyrus-imapd-master #1059

[Bron Gondwana]

On Wed, Jan 2, 2013, at 10:16 AM, Sébastien Michel wrote:
> 2013/1/1 Jenkins <do-not-reply at cyrusimap.org>:
> > See <http://ci.cyrusimap.org/job/cyrus-imapd-master/1059/>
> >
> 
> > checking for pkg-config... /usr/bin/pkg-config
> > checking pkg-config is at least version 0.9.0... yes
> > checking for JANSSON... no
> > configure: error: jansson 2.0 or later was not found, but is required to enable mailbox event notification
> > + fatal 'Cannot run configure'
> > + echo 'imapd/tools/jenkins-build.sh: Cannot run configure'
> > imapd/tools/jenkins-build.sh: Cannot run configure
> > + exit 1
> > Build step 'Execute shell' marked build as failure
> > Skipping Cobertura coverage report as build was not SUCCESS or better ...
> > Recording test results
> 
> 3 options in this case:
> - Install jansson library on the jenkins server
> - Add --disable-event-notification in the Cyrus build script
> - Disable event notification by default at compile time and replace
> --disable-event-notification by --enable-event-notification
> 
> my preference is for option 1

Sounds good to me.  I had a brief glance through today.  It looks nice at
a first reading.  I have a couple of questions:

     - vnd.cmu.newMessages :
       number of unseen messages in the mailbox

I really don't like that name.  Are you strongly attached to it?  I would
be much happier with vnd.cmu.unseenMessages.  Bad names like this which
say something other than what they mean tend to cause bugs in the future.
Unseen is not the same as 'new'.

    and this additionnal event type :
     - vnd.cmu.MessageCopy :
       a message has been copied.

Should we do vnd.cmu.MessageMove now that we have the "move" command?

Thanks for your work getting this into mainline.  I built a copy successfully
on my laptop today.  I just need to get an eventsource listener set up now and
play with it!  We're planning to re-implement some of our internal tools using
it as well.

Bron.
-- 
  Bron Gondwana
  brong at fastmail.fm