[PATCH 0/4] Add VACATION :seconds support
brong at fastmail.fm
Wed May 9 02:34:49 EDT 2012
On Wed, May 09, 2012 at 12:08:53PM +1000, Greg Banks wrote:
> On Tue, May 8, 2012, at 01:52 PM, Bron Gondwana wrote:
> > On Tue, May 8, 2012, at 01:50 PM, Philipp Hahn wrote:
> > > Hello,
> > >
> > > Am Dienstag 08 Mai 2012 13:07:04 schrieb Bron Gondwana:
> > > > On Tue, May 8, 2012, at 11:54 AM, Philipp Hahn wrote:
> > > > > For converting days to seconds and the inverse I always explicitly wrote
> > > > > 24 * 60 * 60. Is there a good location for defining this as a macro?
> > > >
> > > > lib/util.h ?
> > >
> > > Will take a look. Would the following be fine:
> > > #define DAY2SEC(x) ((x) * 24 * 60 * 60)
> > > Or is there a more preferrable name?
> > That's clear. I'm fine with it.
> There's a lib/times.h which has a significant part of the other time
> handling declarations in it.
(this is what happens when someone actually looks at the code rather
than answering off the cuff)
Thanks Greg - lib/times.h sounds like the right home.
And thanks Phillip for your work on this - I really appreciate the
effort to get it "right" and your contribution back to the project.
More information about the Cyrus-devel