Build failed in Jenkins: cyrus-imapd-master #507

[Bron Gondwana]

On Wed, Apr 11, 2012 at 09:26:39AM +1000, Greg Banks wrote:
> 
> 
> On Tue, Apr 10, 2012, at 05:09 PM, Jenkins wrote:
> > See <http://ci.cyrusimap.org/job/cyrus-imapd-master/507/>
> > 
> 
> > Test failures and errors summary
> > ================================
> > 
> > Cassandane::Cyrus::Lsub.lsub_toplevel
> >     http://ci.cyrusimap.org/job/cyrus-imapd-master/507//testReport/%28root%29/Cassandane__Cyrus__Lsub/test_lsub_toplevel/
> > 
> 
> 
> The Lsub tests were using this syntax to create a user
> 
>     # sub folders of another user - one is subscribable
>     $self->{instance}->create_user("other",
> 				   subdirs => [ qw(sub sub.folder) ]);
> 
> A recent change to support running tests with unixhierarchysep=on made
> the checking in create_user() stricter and it now rejects 'sub.folder'
> because it contains the default hierarchy separator.  Creating a 2-level
> folder is a perfectly reasonable thing to want to do here, so I fixed
> this by adding a new syntax to support that without the ambiguity:
> 
>     # sub folders of another user - one is subscribable
>     $self->{instance}->create_user("other",
> 				   subdirs => [ 'sub', ['sub', 'folder']
> 				   ]);
> 
> Fixed in
> http://git.cyrusimap.org/cassandane/commit/?id=cb4a4480ec1a90e40e08482130432062469e558d

That looks sensible.  I did it slightly differently for my little scripts,
I created a function _f, and so you would do $mb->create(_f("sub/folder"))
and it would use the correct dots or slashes, and prepend the INBOX,
depending on the config variables.

Bron.