MESSAGE quota resource implemention
Greg Banks
gnb at fastmail.fm
Sun Sep 4 23:48:17 EDT 2011
On 01/09/11 03:21, Bron Gondwana wrote:
> On Wed, Aug 31, 2011 at 05:50:36PM +0200, Julien Coloos wrote:
>> Things that may be worth noting:
>> - DUMP/UNDUMP currently does nothing special about MESSAGE or
>> X-ANNOTATION-STORAGE quota resources
>> -> should it be transferred ?
>
> I'd like to replace DUMP/UNDUMP with replication protocol
> communications for XFER.
>
>> -> without breaking backward compatibility, limits could only be
>> transferred through a 'fake' file entry, as for annotations
>
> But for now, that's definitely the pragmatic way to go.
>
>> - quota usage is currently stored in a uquota_t variable, and
>> delta is computed as quota_t; so theorically there could be overflow
>> issues if quota usage to add/substract cannot be held in a quota_t;
>> in practice it should be unlikely since that would mean a usage of
>> over 2^63-1
>
> I propose we scrap uquota_t - it is un-necessary for the medium-term
> future, now that we're requiring 64 bit types.
Agreed, and done:
https://github.com/gnb/cyrus-imapd/commit/836eae7b4bda663882c7f135e76b7453b1665436
--
Greg.
More information about the Cyrus-devel
mailing list