[PATCH] Fix incorrect readlink() buffer handling

Bron Gondwana brong at fastmail.fm
Thu Oct 13 05:18:33 EDT 2011


On 10/13/2011 11:12 AM, Thomas Jarosch wrote:
> Hi Bron,
>
> On Thursday, 13. October 2011 11:03:16 you wrote:
>> On 10/13/2011 10:13 AM, Thomas Jarosch wrote:
>>> Also don't mix tabs and spaces.
>> Please don't do this.  I know the tabs/spaces standard is ugly, but
>> that's what this codebase has.
> Normally I try to avoid such changes. I was unsure in this case and oriented
> myself at the function below it, which doesn't use tabs at all.
> "astyle" anyone? ;)
>
> What about the actual code change?
The code looks good, thanks.  Do you want me to push it to git master?

Bron.


More information about the Cyrus-devel mailing list