In master/master.c:add_service the variable "cmd" is set to NULL before syslogging it

Kristóf Katus kristof.katus at intra2net.com
Tue Jul 26 12:59:27 EDT 2011


Hi there, 

In cyrus-imapd-2.4.10/master/master.c:add_service at line 1486 the variable 
char *cmd should not be set to NULL at that point, because the syslog function 
is going to log nothing at line 1534, right? 

The line "cmd = NULL; /* avoid freeing it */" at 1486 should be simply moved 
to line 1539, after the syslog call, I think. Patch attached. Bugzilla report 
is here: https://bugzilla.cyrusimap.org/show_bug.cgi?id=3497

Kristóf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cyrus-imapd-2.4.10-syslogging-bugfix-in-master.patch
Type: text/x-patch
Size: 1396 bytes
Desc: not available
Url : http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20110726/bad46e50/attachment.bin 


More information about the Cyrus-devel mailing list