debian patches to Shell.pm and sieveshell.pl

[Patrick Goetz]

This time I'm just attaching a patch file (unified diff format) for 
reference -- hopefully it's relatively clear how to read it.  I've never 
used Shell.pm, but I do know perl.  With the exception of the first 
patch (Shell.pm, line 127), which I don't understand, these all seem 
fairly reasonable (I've included my notes below the patch line numbers)

~/perl/imap/IMAP/Shell.pm git/perl/imap/IMAP/Shell.pm
-----------------------------------------------------
@@ -127,7 +127,7 @@

I'm not sure what this one does......

@@ -439,7 +439,7 @@

Most people/distros don't seem to use /usr/local much any more, which 
lsb reserves for machine-local files (don't know about BSD or Solaris, 
which probably uses /opt).  The patch + location (/etc/cyradmrc.pl) is 
not so great, either.  Maybe this file should go here: 
/etc/cyrus/cyradmrc.pl?  Seems like any hardwired rc file location is 
probably a bad idea.

@@ -472,7 +472,7 @@

check to see if $mech is defined for a better error message when not.

@@ -1437,7 +1437,7 @@
@@ -1446,7 +1446,7 @@

these are related to the first patch on Line 127


~/perl/sieve/scripts/sieveshell.pl
---------------------------------
(there should probably be a separate patch file for each file being 
patched, especially when there are only 2 and they live in different 
trees; I'll fix this when the patches get updated)

@@ -61,7 +61,9 @@
@@ -69,7 +71,9 @@
@@ -84,20 +88,24 @@
@@ -122,6 +130,8 @@

All these patches deal with adding the ability to pass a password and/or 
execution file on the command line

@@ -172,6 +182,8 @@
@@ -198,6 +210,9 @@
@@ -207,6 +222,9 @@
...
@@ -256,25 +283,32 @@

These set and use a local exitcode variable for clearer/cleaner exit 
code handling.

@@ -284,7 +318,8 @@
etc

update perldoc strings to reflect adding command line password and 
execution file options.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 65-sieveshell-enhancements.dpatch
Url: http://lists.andrew.cmu.edu/pipermail/cyrus-devel/attachments/20100616/ae81c49f/attachment.ksh