Patches not taken up by upstream

Wesley Craig wes at umich.edu
Mon Jun 14 22:46:58 EDT 2010


Seems like a reasonable suggestion.  Where was it reported, exactly?

:wes

On 14 Jun 2010, at 17:46, Patrick Goetz wrote:
> I'm trying to work through the patch list for currently incomplete  
> debian/Ubuntu cyrus 2.3.16 packages  (the version of cyrus  
> currently available on debian/Unbuntu is 2.2.13) in order to get an  
> up to date version of cyrus back into the debian package stream.
>
> Hopefully someone can humor me by explaining why certain really old  
> patches weren't accepted upstream.  I'll post them one at a time to  
> avoid confusion.
>
> ~/sieve/script.c
> line 529 reads:
> ---------------
> syslog(LOG_DEBUG, "IOERROR: fstating sieve script %s: %m", fname);
> ----------------
>
> several years ago the debian people suggested:
> ----------------
>   if (errno == ENOENT) {
>      syslog(LOG_DEBUG, "WARNING: sieve script %s doesn't exist: % 
> m", fname);
>   } else {
>      syslog(LOG_DEBUG, "IOERROR: fstating sieve script %s: %m",  
> fname);
>   }
> ----------------
>
> instead.  This seems like a sensible refinement -- any idea why  
> this didn't make it into upstream source?  Do some cyrus-supported  
> systems not have <errno.h> available?


More information about the Cyrus-devel mailing list