master process handling patch

Henrique de Moraes Holschuh hmh at
Fri Jul 2 23:11:24 EDT 2010

On Fri, 02 Jul 2010, Patrick Goetz wrote:
> This is another debian patch with lots of changes (see attached).
> I'm running out of time for tracing the validity of these and am
> hoping that someone else will take a look. This seems to apply to a
> rather important part of the whole system, so is probably worth a
> look.
> (Yes, I can submit this to bugzilla, too, if it makes sense to do
> so.) Note one minor bug fix in the patch:
>   +int read_msg(int fd, struct notify_message *msg)
>   +{
>   +    ssize_t r;
>   +    size_t off = 0;
>   +    int s = sizeof(struct notify_message);
> should be
> ------ --
>   +int read_msg(int fd, struct notify_message *msg)
>   +{
>   +    ssize_t r;
>   +    size_t off = 0;
>   +    size_t s = sizeof(struct notify_message);

No. As I said in the debian cyrus devel list, either ssize_t s =, or
leave it as int.  No reason to have signed/unsigned math for something
like that.

Also, we have metadata for why this thing exists, it was added by me to
Debian Cyrus 2.1 because of problems seen in the field.  We have the
problem documented, and the name of the reporter and tester, changelog
entries of that time, etc.  I didn't have time to send it in yet.

Comments on the patch are welcome, but please don't merge it as is.  I
will clean it up a bit and add the relevant metadata on why it exists
and what it attempts to do.

Also, this thing should really be two or three separate patches :p and
the manpage needs to document "-J".

> diff -urNad git~/master/master.h git/master/master.h
> --- git~/master/master.h	2010-01-16 19:21:09.000000000 -0200
> +++ git/master/master.h	2010-01-16 19:28:14.289091714 -0200
> @@ -45,6 +45,7 @@
>  extern struct service *Services;
>  extern int allocservices;
>  extern int nservices;
> +void sighandler_setup(void);
>  /*
>   * Description of multiple address family support from

This hunk can be dropped.

  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

More information about the Cyrus-devel mailing list