[PATCH] Allow setting custom annotations through cyradm

[Bron Gondwana]

On Wed, Aug 18, 2010 at 07:35:27PM +0100, Jeroen van Meeuwen (Kolab Systems) wrote:
> Jeroen van Meeuwen (Kolab Systems) wrote:
> > Hello,
> > 
> > please find attached a patch, that allows the configuration of custom 
> > annotations on mailboxes through cyradm.sh.
> > 
> > This patch had been pending submission for a while, as it depended on the 
> > annotation_definitions patch accepted in 2.3.16[1].
> > 
> > I hope you will find this patch applies to CVS HEAD cleanly.
> > 
> > [1] http://lists.andrew.cmu.edu/pipermail/cyrus-announce/2009-
> > December/000069.html
> > 
> 
> Ping, this seems like a pretty straight-forward patch.
> 
> Can I get some feedback please?

Yeah - it looks fine.  I personally wouldn't do:

if ($a) {
  thing();
} else {
  other_thing() unless $b;
}

I'd write it:

if ($a) {
  thing()
} elsif (not $b) {
  other_thing();
}

or even:

if ($a) {
  thing();
} elsif ($b) {
  # nothing to do
} else {
  other_thing();
}

if you want full case coverage!

But that's just nit-pickery.  I have no objecting to this going straight
in to CVS.

Bron.