Time for 2.3.13?

Bron Gondwana brong at fastmail.fm
Fri Sep 12 10:59:43 EDT 2008

On Fri, 12 Sep 2008 10:39:50 +0200, "Thomas Jarosch" <thomas.jarosch at intra2net.com> said:
> Bron,
> I've quickly reviewed your patches and put them in our production server.
> Seems to work fine :-)
> Maybe the comment of the "cyrus-always-unlink-2.3.12.diff" patch can be 
> expanded a bit so I won't be removed in the future again: unlink() is
> normally 
> not needed as fopen(stagefile, "w+") will truncate the file if it exists.
> The patch is still good as it will remove files with wrong access
> permissions.

Yeah, good point.  The problem with truncating the file of course is that
it also truncates the hard linked copy sitting in somebody's spool somewhere,
which causes random emails to appear where they shouldn't and is very
very bad!
  Bron Gondwana
  brong at fastmail.fm

More information about the Cyrus-devel mailing list