bug in the proxy module ...

[Ken Murchison]

I haven't run into this, but you can try changing the while clause to:

while (c == sizeof(buf) && buf[sizeof(buf)-1] != '\n')

This is completely untested and may have unintended side-effects.


Brasseur Valery wrote:
> Hi,
> 
> I am using cyrus 2.3.11 in a murder setup... from time to time have got an hang from the pop3 proxyd ...
> 
> I nail it donw to the following portion of code :
> in imap/proxy.c near line 266 :
> <quote>
>        if (pout) {
>                 const char *err;
>                 char buf[4096];
>                 int c;
> 
>                 do {
>                     c = prot_read(pin, buf, sizeof(buf));
> 
>                     if (c == 0 || c < 0) break;
>                     prot_write(pout, buf, c);
>                 } while (c == sizeof(buf));
> 
>                 if ((err = prot_error(pin)) != NULL) { </quote>
> 
> from time to time, the prot_read return exactly 4096 bytes, but it's the end of the message...
> so backend seat and wait for next command, and proxy seat and wait for the next buffer ...
> forever !
> 
> for me it's seems that the condition " c == sizeof(buf)" is not enough in that case.
> 
> 
> 
> have someone else already encoutered this ?
> 
> 
> thanks
> valery
> 
> 
> 
> 
> Ce message et les pi?ces jointes sont confidentiels et r?serv?s ? l'usage exclusif de ses destinataires. Il peut ?galement ?tre prot?g? par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir imm?diatement l'exp?diteur et de le d?truire. L'int?grit? du message ne pouvant ?tre assur?e sur Internet, la responsabilit? du groupe Atos Origin ne pourra ?tre recherch?e quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'exp?diteur ne donne aucune garantie ? cet ?gard et sa responsabilit? ne saurait ?tre recherch?e pour tout dommage r?sultant d'un virus transmis.
> 
> This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos Origin group liability cannot be triggered for the message content. Although the sender endeavours to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.
> 
> 


-- 
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University