Two more patches

Ken Murchison murch at andrew.cmu.edu
Wed Oct 24 09:50:26 EDT 2007


Bron Gondwana wrote:
> On Wed, 24 Oct 2007 07:55:55 -0400, "Ken Murchison" <murch at andrew.cmu.edu> said:
>> It look to me like we bail out if we are missing a message listed in 
>> cyrus.expunge.  Is this correct?  Do we want to abort a reconstruct in 
>> this case?
> 
> No, just strip the record from the .expunge file.  I didn't change the
> expected behaviour (from what I could see of the code), just the
> correctness of the generated file.

OK, but what does this code check for?

	if (expuid_pos != expuid_idx) {
	    syslog (LOG_ERR,
		    "IOERROR: %m failed to find all records for: %s",
		    newfnamebuf);
	    close(expunge_fd);
	    map_free(&index_base, &index_len);
	    free(expuid);
	    fclose(fexpunge);
	    return IMAP_IOERROR;
	}

-- 
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University


More information about the Cyrus-devel mailing list